When you review a teammate's pull request, what do you look for, and how do you give feedback they will actually act on?

What the interviewer is looking for

• This question tests code review & collaboration. Reviews for correctness, clarity and risk rather than style nitpicks, gives specific and kind feedback, and accepts feedback on their own code without defensiveness.
• Strong answers: Correctness, edge cases, readability, tests and risk before style, separating blocking issues from suggestions, asking questions, and keeping a respectful tone.
• Likely follow-up: How do you handle it when someone disagrees with your review comment?

Another way it may be asked: A colleague sends you a few hundred lines to review. What are you checking for, and how do you word your comments?

A structure to follow: Answer, explain, example, limits

1. Step 1

   Answer

   Give your direct answer in the first sentence so the interviewer knows where you are going.

2. Step 2

   Explain

   Say how it works or why you would do it that way, in plain words before jargon.

3. Step 3

   Example

   Anchor it in something you have actually done or seen, with the detail that shows hands-on experience.

4. Step 4

   Limits

   Say when your approach would not be the right one. It shows judgement.

This is guidance on shape, not a script. Use your own real experience and facts; never invent details to fill a gap. See the STAR guide and answer frameworks.

Common slips

• Reciting a definition without showing you have applied it.
• Using terms you cannot explain if asked a level deeper.
• Claiming experience beyond what you can discuss in detail.

How to practise it

Say the answer in 90 seconds, then answer the follow-up as if it were a new question.

Related questions

• When would you pick a hash map over a list to store data, and what does that choice cost you?
• Imagine your code works on your laptop but fails in the test environment. Walk me through how you would start figuring out why.
• How do you usually use Git day to day, from starting a piece of work to getting it merged?
• How do you decide what to test in a new feature, and how do you balance unit tests against integration tests?
• Tell me about the trickiest bug you have tracked down. How did you find the root cause?

Browse all questions